-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/iri widget enhancement #86
Conversation
Make the external icon optional to render. Default is true.
Add URL prefix to iri link if provided. Iri get encoded in this case.
Add a copy to clipboard button for iri. Default is false.
Add new stories for the iriWidget added features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice new features! Please also add stories to the HTML Storybook, by exporting them in the IriWdgetHTML.stories.ts. I will adapt the readme and make it more clear for developers to update both, the React and html stories (#88)
And please merge the latest changes I made on the main branch, since this will activate the build check for pull requests. Thank you :)
Add the new stories for the HTML version.
Not ready yet. The new features do not work in the HTML version for some unknown reason. The stories are there but the input props have no effect. |
src/app/types.ts
Outdated
/** | ||
* Indicates that the target is external and needs an icon. | ||
*/ | ||
externalIcon?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use boolean? same for copyButton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes true. I can't remember why I set it to string. I will do a fix-commit for this.
change the boolean types to boolean. Refactor the story. Use color also for the copy button.
🎉 This PR is included in version 2.0.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Related to #84
Added Features: